Logging improvements · Pull Request #5749 · scality/cloudserver

ghost · 2025-02-26T09:59:08Z

Improve logging to use better levels, or add logs that were missing in routeBackbeat.
The delete operation also will log a warning when the expiration tries to delete a master version (due to any race condition).

Also bump Arsenal from scality/Arsenal#2300

bert-e · 2025-02-26T09:59:11Z

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-02-26T09:59:23Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-613 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

8.8.44
9.0.3

Please check the Fix Version/s of CLDSRV-613, or the target
branch of this pull request.

codecov · 2025-02-26T09:59:44Z

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.30%. Comparing base (cd82656) to head (4e41fa7).
Report is 10 commits behind head on development/8.8.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
lib/routes/routeBackbeat.js	90.00%	1 Missing ⚠️
lib/server.js	0.00%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/api/apiUtils/object/abortMultipartUpload.js	`84.81% <100.00%> (ø)`
lib/api/apiUtils/object/coldStorage.js	`97.80% <100.00%> (+3.42%)`	⬆️
lib/api/apiUtils/object/objectRestore.js	`81.94% <100.00%> (ø)`
lib/api/objectDelete.js	`84.48% <100.00%> (+5.53%)`	⬆️
lib/routes/routeVeeam.js	`69.62% <100.00%> (+10.12%)`	⬆️
lib/routes/routeBackbeat.js	`33.33% <90.00%> (+10.87%)`	⬆️
lib/server.js	`0.00% <0.00%> (ø)`

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/8.8    #5749      +/-   ##
===================================================
+ Coverage            64.47%   65.30%   +0.83%     
===================================================
  Files                  185      185              
  Lines                11641    11646       +5     
===================================================
+ Hits                  7505     7606     +101     
+ Misses                4136     4040      -96

Flag	Coverage Δ
unit	`65.30% <90.47%> (+0.83%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lib/api/apiUtils/object/coldStorage.js

lib/api/apiUtils/object/objectRestore.js

lib/api/completeMultipartUpload.js

lib/routes/routeBackbeat.js

package.json

lib/api/objectDelete.js

ghost · 2025-03-11T07:38:39Z

/approve

- From info to debug when applicable - From info to warn or error Issue: CLDSRV-613

Issue: CLDSRV-613

This does not prevent any race condition but at least leaves a log when it happens. Issue: CLDSRV-613

Issue: CLDSRV-613

bert-e · 2025-03-13T11:44:30Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/8.8
✔️ development/9.0

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70

Please check the status of the associated issue CLDSRV-613.

Goodbye williamlardier.

The following options are set: approve

ghost force-pushed the improvement/CLDSRV-613 branch 6 times, most recently from 3b3a567 to 18cac34 Compare February 26, 2025 16:10